double check the axle nut. it should be torqued to 213 lb-ft, also double check the lug nuts are tight. in either case the wheel can wobble which can cause a strange knocking noise.
Even though it's been a week I still didn't see a solutilon... The spring is on the wrong side of the saddle.
If you pause the video (wheel off) toward the end of the video (when you're panning out from the inner cv joint) it's very clear... You can also see that the caliper isn't parallel to the bracket.
Same thing happened to me on the last front brake job... spring popped a couple days after...
Just use a big flat screwdriver and wedge the spring to the other side of the saddle.